Scoped Observe #109
Merged
Scoped Observe #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
AtomScope.observe(_:)has been working implicitly as scoped observation which receives state changes of atoms used in the scope, so this PR is to make it explicit along with renaming the function name toscopedObserve(_:).Lthough it was originally a scoped observation, it has been receiving state changes triggered by nested scopes as well but it's no longer be received by this PR.
To receive whole app state changes, use
AtomRoot.observe(_:)instead. Also, to rceive state changes triggered by nested multiple scopes, useAtomScope.init(inheriting:)to inherit obsevers from ancestor scopes.Impact on Existing Code
AtomScope.observe(_:)is deprecated and renamed toAtomScope.scopedObserve(_:).