Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QuestBudget Fee Calculation #289

Merged
merged 10 commits into from
Jul 19, 2024
Merged

Conversation

jonathandiep
Copy link
Contributor

No description provided.

@@ -85,6 +86,7 @@ contract QuestFactory is Initializable, LegacyStorage, OwnableRoles, IQuestFacto
referralFee = referralFee_;
mintFee = mintFee_;
referralRewardTimestamp = block.timestamp;
referralRewardFee = 250; // in BIPS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The referralFee on line 86 refers to the referral fees on the claim fee (which is currently set to 0 ETH)

@jonathandiep jonathandiep changed the title Jon/update quest budget fee Update QuestBudget Fee Jul 18, 2024
@jonathandiep jonathandiep marked this pull request as ready for review July 18, 2024 00:15
@jonathandiep jonathandiep requested a review from a team as a code owner July 18, 2024 00:15
@jonathandiep jonathandiep changed the title Update QuestBudget Fee Update QuestBudget Fee Calculation Jul 18, 2024
Copy link
Member

@Quazia Quazia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:

@jonathandiep jonathandiep merged commit 7dfbe0f into main Jul 19, 2024
2 checks passed
@jonathandiep jonathandiep deleted the jon/update-quest-budget-fee branch July 19, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants