Make some OAuth2 settings optional #12258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
MarcialRosales
force-pushed
the
make-some-oauth2-settings-optional
branch
3 times, most recently
from
043520f
to
f6dd1e0
Compare
MarcialRosales
force-pushed
the
make-some-oauth2-settings-optional
branch
8 times, most recently
from
ecac15f
to
3a210d7
Compare
MarcialRosales
force-pushed
the
make-some-oauth2-settings-optional
branch
4 times, most recently
from
a216551
to
99838c3
Compare
Improve logging Fix an issue running selenium tests locally WIP modify schema to configure queryParameters for oauth2 endpoints
before implementing oidc endpoints parameters
split rabbit_oauth2_config into - rabbit_oauth2_resource_server - rabbit_oauth2_oauth_provider and their respective test modules Signing keys is an oauth provider concern hence it stays with the oauth_provider module.
Fixing test cases
Pending to add more scenarios whch combine +2 resources with and without verify_aud and with and without audience in token
WIP address a dialyzer error
to be able to set extra parameters for authorize and token endpoints
Add javascript unit tests given that amount of javascript code it is difficult to get good coverage with just end-to-end tests The tests are not running yet because i need to learn how to use Babel to convert ES5 modules into NodeJs modules otherwise it is not possible because all the source modules use ES5 modules whereas tests run from node.js which requires CommonJS
And fix selenium script to run rabbitrmq locally
And location of cert files when running multioauth test suites locally
MarcialRosales
force-pushed
the
make-some-oauth2-settings-optional
branch
from
378bbb2
to
697b5a2
Compare
This was referenced Oct 2, 2024
michaelklishin
requested changes
Oct 4, 2024
There was a problem hiding this comment.
@MarcialRosales we cannot use very generic modules names such as rar and oauth2, or keycloak.
We should continue using the rabbit_oauth2_ prefix in this plugin to avoid potential code path conflicts with external libraries, other plugins, and so on.
| %% Copyright (c) 2007-2024 Broadcom. All Rights Reserved. The term “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. All rights reserved. | ||
| %% | ||
|
|
||
| -module(resource_server). |
There was a problem hiding this comment.
This is a very generic name, we should continue using rabbit_oauth2_ for prefix.
There was a problem hiding this comment.
I see. I wanted to make it simpler but clearly I went over the line :) . Thanks Michael.
| %% | ||
|
|
||
| % Rich Authorization Request | ||
| -module(rar). |
There was a problem hiding this comment.
This is a very generic and short name, we should continue using rabbit_oauth2_ for prefix.
| %% Copyright (c) 2007-2024 Broadcom. All Rights Reserved. The term “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. All rights reserved. | ||
| %% | ||
|
|
||
| -module(oauth_provider). |
There was a problem hiding this comment.
This is a very generic name, we should continue using rabbit_oauth2_ for prefix.
| %% Copyright (c) 2007-2024 Broadcom. All Rights Reserved. The term “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. All rights reserved. | ||
| %% | ||
|
|
||
| -module(keycloak). |
There was a problem hiding this comment.
This is a very generic name, we should continue using rabbit_oauth2_ for prefix.
- Use rabbit_oauth2 prefix for modules which do not have it - Ensure most lines stick to 80 column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implements features:
management.metadata_urland move it toauth_oauth2.discovery_endpoint_path#12237It is accompanied by this docs PR rabbitmq/rabbitmq-website#2056
Tasks:
oauth_providerandresource_servertypes rather than asking for each setting to the deprecated config module. Split config module into oauth_provider and resource_server modules.discovery_endpoint_pathanddiscovery_endpoint_paramsoauth_authorization_endpoint_paramsandoauth_token_endpoint_paramsaccess_token_requestanddiscovery_endpointto theoauth_providertype. (TODO the WSR plugin should be updated to read these extra params and pass them to theaccess_token_request)Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply