Write to the outgoing pipeline directly #245
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great @lukebakken ! |
lukebakken
force-pushed
the
lukebakken/write-to-pipeline-directly
branch
from
638369b to
1606f7b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 92.80% 93.11% +0.30%
==========================================
Files 102 102
Lines 8869 8810 -59
Branches 704 676 -28
==========================================
- Hits 8231 8203 -28
+ Misses 492 468 -24
+ Partials 146 139 -7
☔ View full report in Codecov by Sentry. |
lukebakken
force-pushed
the
lukebakken/write-to-pipeline-directly
branch
from
4579c18 to
025a12a
Compare
lukebakken
force-pushed
the
lukebakken/write-to-pipeline-directly
branch
from
12b2d60 to
9bbd2cd
Compare
|
Have you tried the perf test with this PR to see if there is any improvement? |
lukebakken
force-pushed
the
lukebakken/write-to-pipeline-directly
branch
3 times, most recently
from
837d49b to
2ef446a
Compare
See: https://blog.marcgravell.com/2018/07/pipe-dreams-part-3.html#writes-and-wrongs * Fixup API validation * Add assertion * Fix a missing Advance/1 call * Add FUTURE * Replace span slices with range operator. * Fix name violations * Add missing `writer.Advance` calls * Fix writing the command payload size. * Add more missing `writer.Advance` calls * Update dependency versions for CI
lukebakken
force-pushed
the
lukebakken/write-to-pipeline-directly
branch
from
a960cb0 to
3cf0d51
Compare
SoftStoneDevelop
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still have benchmarking to do, but this method should be faster.
Learning a bit after reading about
System.IO.Pipelines- link