Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file for strong naming assembly #266

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukebakken
Copy link
Contributor

If you use sn -T on the version 1.3.0 RabbitMQ dll, you get this:

lib\net6.0> sn -T .\RabbitMQ.Stream.Client.dll

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

.\RabbitMQ.Stream.Client.dll does not represent a strongly named assembly

@lukebakken lukebakken self-assigned this May 3, 2023
@lukebakken lukebakken added this to the 2.0.0 milestone May 3, 2023
@lukebakken
Copy link
Contributor Author

This probably will have to be a 2.0.0 thing.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03% 🎉

Comparison is base (2f1be23) 93.01% compared to head (077f364) 93.05%.

❗ Current head 077f364 differs from pull request most recent head 20f34cd. Consider uploading reports for the commit 20f34cd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   93.01%   93.05%   +0.03%     
==========================================
  Files         107      104       -3     
  Lines        9204     9139      -65     
  Branches      724      722       -2     
==========================================
- Hits         8561     8504      -57     
+ Misses        496      489       -7     
+ Partials      147      146       -1     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zerpet
Copy link
Contributor

Zerpet commented May 4, 2023

Building from this PR and running the same command yields:

sn -T RabbitMQ.Stream.Client/bin/Debug/net6.0/RabbitMQ.Stream.Client.dll
Mono StrongName - version 6.12.0.0
StrongName utility for signing assemblies
Copyright 2002, 2003 Motus Technologies. Copyright 2004-2008 Novell. BSD licensed.

Public Key Token:

Does it mean it has strong assembly? 🙈
This was on Mac OS.

@lukebakken
Copy link
Contributor Author

You know I could actually have tested that 🤦

@lukebakken lukebakken requested a review from Zerpet May 9, 2023 14:50
@lukebakken lukebakken force-pushed the lukebakken/add-strong-name-file branch from 1008cdd to c974960 Compare May 9, 2023 14:51
@lukebakken
Copy link
Contributor Author

Hmm the tests run fine in my Ubuntu / WSL environment, I don't see this error:

System.MethodAccessException : Attempt by method 'Tests.ConsumerSystemTests+<ConsumerValidationAmqpAttributes>d__8.MoveNext()' to access method 'RabbitMQ.Stream.Client.Message.set_Annotations(RabbitMQ.Stream.Client.AMQP.Annotations)' failed.

I'll figure it out. It has to do with the InternalsVisisbleTo attribute that allows the tests project to use internal types.

@lukebakken lukebakken force-pushed the lukebakken/add-strong-name-file branch from 6daa77e to 5735010 Compare May 10, 2023 14:15
@Zerpet
Copy link
Contributor

Zerpet commented May 10, 2023

I get a public key token now:

sn -T RabbitMQ.Stream.Client/bin/Debug/net6.0/RabbitMQ.Stream.Client.dll
Mono StrongName - version 6.12.0.0
StrongName utility for signing assemblies
Copyright 2002, 2003 Motus Technologies. Copyright 2004-2008 Novell. BSD licensed.

Public Key Token: f7b36e2fabae37d5

Should be good to go when CI passes 👍

Zerpet
Zerpet previously approved these changes May 10, 2023
@lukebakken lukebakken force-pushed the lukebakken/add-strong-name-file branch from 5735010 to a61acaf Compare May 10, 2023 18:08
Zerpet
Zerpet previously approved these changes May 11, 2023
@lukebakken lukebakken force-pushed the lukebakken/add-strong-name-file branch from 3ff004d to 51c3a8c Compare June 20, 2023 18:15
@lukebakken lukebakken force-pushed the lukebakken/add-strong-name-file branch from 51c3a8c to 20f34cd Compare July 28, 2023 20:12
@lukebakken lukebakken force-pushed the lukebakken/add-strong-name-file branch 2 times, most recently from eca424e to d419b97 Compare July 25, 2024 15:33
If you use `sn -T` on the version 1.3.0 RabbitMQ dll, you get this:

```
lib\net6.0> sn -T .\RabbitMQ.Stream.Client.dll

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

.\RabbitMQ.Stream.Client.dll does not represent a strongly named assembly
```

Actually do the signing correctly. Thanks for double-checking @Zerpet

Add `AltCoverStrongNameKey` to fix builds using AltCover
@lukebakken lukebakken force-pushed the lukebakken/add-strong-name-file branch from d419b97 to de82880 Compare July 25, 2024 15:49
@Gsantomaggio Gsantomaggio added the v2 Version 2 label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Version 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants