-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file for strong naming assembly #266
base: main
Are you sure you want to change the base?
Conversation
This probably will have to be a |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
+ Coverage 93.01% 93.05% +0.03%
==========================================
Files 107 104 -3
Lines 9204 9139 -65
Branches 724 722 -2
==========================================
- Hits 8561 8504 -57
+ Misses 496 489 -7
+ Partials 147 146 -1 ☔ View full report in Codecov by Sentry. |
Building from this PR and running the same command yields:
Does it mean it has strong assembly? 🙈 |
You know I could actually have tested that 🤦 |
1008cdd
to
c974960
Compare
Hmm the tests run fine in my Ubuntu / WSL environment, I don't see this error:
I'll figure it out. It has to do with the |
6daa77e
to
5735010
Compare
I get a public key token now:
Should be good to go when CI passes 👍 |
5735010
to
a61acaf
Compare
3ff004d
to
51c3a8c
Compare
51c3a8c
to
20f34cd
Compare
eca424e
to
d419b97
Compare
If you use `sn -T` on the version 1.3.0 RabbitMQ dll, you get this: ``` lib\net6.0> sn -T .\RabbitMQ.Stream.Client.dll Microsoft (R) .NET Framework Strong Name Utility Version 4.0.30319.0 Copyright (c) Microsoft Corporation. All rights reserved. .\RabbitMQ.Stream.Client.dll does not represent a strongly named assembly ``` Actually do the signing correctly. Thanks for double-checking @Zerpet Add `AltCoverStrongNameKey` to fix builds using AltCover
d419b97
to
de82880
Compare
If you use
sn -T
on the version 1.3.0 RabbitMQ dll, you get this: