Fixed argument passing to the ldap keyword + logging #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, the argument connection was simply ignored because the syntax for the "plugin_args" is "plugin_args(@_)", not simply "plugin_args". Which, btw, is totally useless as D2 plugins wants the Dancer2 namespace. This change comes with two test files which use a public LDAP server for testing. The first file 01-bare-ldap.t will try to contact the public box and write out a ldap.conf file in the t/ directory, which in turn will be used by our tests in t/ldap.t
This way we can have a Dancer[1,2]-agnostic handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the argument connection was simply ignored
because the syntax for the "plugin_args" is "plugin_args(@_)", not
simply "plugin_args".
Which, btw, is totally useless as D2 plugins wants the Dancer2
namespace.
This change comes with two test files which use a public LDAP server
for testing.
The first file 01-bare-ldap.t will try to contact the public box and
write out a ldap.conf file in the t/ directory, which in turn will be used
by our tests in t/ldap.t
This pull request will also bring in the logging change.
Implemented logging in the Handle with coderefs.
This way we can have a Dancer[1,2]-agnostic handle.