Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudfeeds customer access events #726

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

manishtomar
Copy link
Contributor

Implement API to provide customer access events in cloud feeds format. This is based on https://one.rackspace.com/display/CUST/Access+Policy.

@codecov-io
Copy link

codecov-io commented Jan 20, 2017

Codecov Report

Merging #726 into master will decrease coverage by -0.03%.
The diff coverage is 97.61%.

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
- Coverage    99.6%   99.57%   -0.03%     
==========================================
  Files          79       80       +1     
  Lines        5564     5648      +84     
  Branches      784      795      +11     
==========================================
+ Hits         5542     5624      +82     
- Misses         10       11       +1     
- Partials       12       13       +1
Impacted Files Coverage Δ
mimic/resource.py 100% <100%> (ø)
mimic/core.py 100% <100%> (ø)
mimic/rest/cloudfeedscap.py 97.46% <97.46%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fcbbed...61ce221. Read the comment docs.

@manishtomar
Copy link
Contributor Author

@glyph sorry I abandoned this :(

@glyph
Copy link
Contributor

glyph commented Feb 23, 2017

@manishtomar No worries! It was closer to finished than I realized. Now we just have to wait 2 or 3 weeks for the Mac build to complete: https://www.traviscistatus.com/#metrics-display-graph-container-7cl94r33fvsg

@glyph
Copy link
Contributor

glyph commented Feb 23, 2017

The one coverage issue here is that there needs to be a test for a direction query parameter other than forwards or backwards.

@glyph
Copy link
Contributor

glyph commented Apr 16, 2017

If someone else would like to move this forward, it just needs test coverage.

@manishtomar
Copy link
Contributor Author

@glyph I'll get this done this week.

@manishtomar
Copy link
Contributor Author

@glyph I can't commit to this branch. Is it possible to give me permission for this repo temporarily?

@BenjamenMeyer
Copy link
Contributor

@manishtomar are you not doing this under your own fork? That would be the best way to do it. Otherwise @lekhajee will probably have to help you out.

@lekhajee
Copy link
Contributor

@manishtomar : Have added you as a collaborator.

@glyph
Copy link
Contributor

glyph commented Apr 28, 2017

Thanks @lekhajee ! Now it's totally on you, @manishtomar :)

@manishtomar
Copy link
Contributor Author

@lekhajee It still shows me a "contributor" instead of "collaborator". interestingly it shows you also as "contributor". Can you please check again?

@manishtomar are you not doing this under your own fork? That would be the best way to do it. Otherwise @lekhajee will probably have to help you out.

@BenjamenMeyer You are right. I should be doing that. It's just that I had committed to this branch and then left rackerlab repo. Now I've a very simple commit to finish the PR and was hoping to add it here instead of creating new PR from fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants