Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds ironic IPA image build tools #308

Merged
merged 1 commit into from
Sep 19, 2024
Merged

feat: Adds ironic IPA image build tools #308

merged 1 commit into from
Sep 19, 2024

Conversation

nicholaskuechler
Copy link
Contributor

No description provided.

@nicholaskuechler nicholaskuechler marked this pull request as ready for review September 17, 2024 17:22
cardoe
cardoe requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely think we need to drop the hardcoded auth and use it dynamically if we need it.

ironic-images/ipa-debian-bookworm/ipa-debian-bookworm.sh Outdated Show resolved Hide resolved
.github/workflows/build-ironic-images.yaml Outdated Show resolved Hide resolved
ironic-images/ipa-debian-bookworm/ipa-debian-bookworm.sh Outdated Show resolved Hide resolved
ironic-images/ipa-debian-bookworm/ipa-debian-bookworm.yaml Outdated Show resolved Hide resolved
ironic-images/ipa-debian-bookworm/ipa-debian-bookworm.yaml Outdated Show resolved Hide resolved
ironic-images/ipa-debian-bookworm/ipa-debian-bookworm.yaml Outdated Show resolved Hide resolved
ironic-images/custom_elements/undercloud-ipa/element-deps Outdated Show resolved Hide resolved
.github/workflows/build-ironic-images.yaml Show resolved Hide resolved
@nicholaskuechler nicholaskuechler force-pushed the build-ipa-image-20240916 branch 3 times, most recently from 976cbd9 to c7cef30 Compare September 17, 2024 22:36
skrobul
skrobul approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@skrobul skrobul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor suggestions, but otherwise lgtm

.github/workflows/build-ironic-images.yaml Outdated Show resolved Hide resolved
ironic-images/custom_elements/undercloud-ipa/install.d/50-PUC-427 Outdated Show resolved Hide resolved
@nicholaskuechler nicholaskuechler force-pushed the build-ipa-image-20240916 branch 3 times, most recently from 859244e to 69ec1a1 Compare September 18, 2024 17:49
cardoe
cardoe approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'll merge this but I don't think we should be publishing a release on a PR. A build is fine.

@cardoe cardoe merged commit 8a4a52d into main Sep 19, 2024
13 checks passed
@cardoe cardoe deleted the build-ipa-image-20240916 branch September 19, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardoe cardoe cardoe approved these changes

@skrobul skrobul skrobul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholaskuechler @cardoe @skrobul