Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skippable provisioning-ingress-nginx #375

Merged
merged 3 commits into from
Oct 16, 2024
Merged

fix: skippable provisioning-ingress-nginx #375

merged 3 commits into from
Oct 16, 2024

Conversation

skrobul
Copy link
Collaborator

@skrobul skrobul commented Oct 15, 2024

These were the changes needed to get the staging environment running.

@skrobul skrobul requested a review from a team October 15, 2024 11:36
cardoe
cardoe requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So they'll fight over the namespace ownership so maybe they need to be in separate namespaces. But you'll need the references. In #377 I changed the reference from secrets to deploy.

apps/appsets/infra.yaml Show resolved Hide resolved
apps/appsets/infra.yaml Show resolved Hide resolved
cardoe
cardoe approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure what's going to happen with the namespace and if we need to figure out how to split the namespaces.

@cardoe cardoe added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 0baf0e6 Oct 16, 2024
13 checks passed
@cardoe cardoe deleted the charlie-staging branch October 16, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardoe cardoe cardoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skrobul @cardoe