Add Debug button to #lang htdp/asl. #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rfindler This avoids the "two syntax-check buttons" problem. |
|
This also makes racket/drracket#592 obsolete. |
rfindler
reviewed
Sep 4, 2024
htdp-lib/htdp/bsl/reader.rkt
Outdated
| @@ -26,15 +26,18 @@ | |||
| (define ((make-info options) key default use-default) | |||
| (case key | |||
| [(drscheme:toolbar-buttons) | |||
| ;; If you want to add more buttons, don't do it this way: | |||
There was a problem hiding this comment.
Maybe we should write something like:
;; if you want to add more buttons, do it this way only
;; if they aren't already built and can just be enabled.
?
There was a problem hiding this comment.
I had trouble parsing this comment; I think you mean
"aren't already (built and can just be enabled)", but I initially read it as "(aren't already built) and (can just be enabled)"... which doesn't really make sense, but maybe something like "aren't already built and enable-able" would be less misunderstandable. Oog.
There was a problem hiding this comment.
How's this:
;; if you want to add more buttons, the strategy used here might not
;; be the right one to use. If you can simply enable existing buttons,
;; do that instead.
mikesperber
force-pushed
the
add-debug-button-to-asl
branch
from
cc1c906
to
8557b65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177.