Skip to content

Commit

Permalink
feat: support custom LDAP group object classes
Browse files Browse the repository at this point in the history
Introduce [ldap]>group_object_classes parameter for the gateway
configuration to support custom group object classes for both
slurm-web-gateway and slurm-web-ldap-check.
  • Loading branch information
rezib committed Aug 30, 2024
1 parent 10269f1 commit 9aa95a7
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 3 deletions.
10 changes: 7 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Explain `[slurmrestd]` > `version` agent setting is more intended for
developers and should not be changed.
- Mention Slurm accounting is required in quickstart guide (#341).
- conf: Add `ldap`>`user_primary_group_attribute` for the gateway.
- gateway: Support custom LDAP user primary group attribute.
- ldap-check: Support custom LDAP user primary group attribute.
- conf:
- Add `ldap`>`user_primary_group_attribute` parameter for the gateway.
- Add `ldap`>`group_object_classes` parameter for the gateway.
- gateway: Support custom LDAP user primary group attribute and group object
classes (#342).
- ldap-check: Support custom LDAP user primary group attribute and group object
classes (#342).

## Changed
- pkgs: Add requirement on RFL.core >= 1.0.3.
Expand Down
7 changes: 7 additions & 0 deletions conf/vendor/gateway.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,13 @@ ldap:
type: str
default: cn
doc: Group entry attribute for name
group_object_classes:
type: list
content: str
default:
- posixGroup
- groupOfNames
doc: List of LDAP object classes for groups
bind_dn:
type: str
doc: |
Expand Down
1 change: 1 addition & 0 deletions slurmweb/apps/gateway.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ def __init__(self, seed):
user_fullname_attribute=self.settings.ldap.user_fullname_attribute,
user_primary_group_attribute=self.settings.ldap.user_primary_group_attribute,
group_name_attribute=self.settings.ldap.group_name_attribute,
group_object_classes=self.settings.ldap.group_object_classes,
cacert=self.settings.ldap.cacert,
starttls=self.settings.ldap.starttls,
bind_dn=self.settings.ldap.bind_dn,
Expand Down
1 change: 1 addition & 0 deletions slurmweb/apps/ldap.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def run(self):
user_fullname_attribute=self.settings.ldap.user_fullname_attribute,
user_primary_group_attribute=self.settings.ldap.user_primary_group_attribute,
group_name_attribute=self.settings.ldap.group_name_attribute,
group_object_classes=self.settings.ldap.group_object_classes,
starttls=self.settings.ldap.starttls,
bind_dn=self.settings.ldap.bind_dn,
bind_password=self.settings.ldap.bind_password,
Expand Down

0 comments on commit 9aa95a7

Please sign in to comment.