Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide users jobs filters when authentication is disabled #337

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

rezib
Copy link
Contributor

@rezib rezib commented Aug 20, 2024

Hide users disclosure from jobs filters panel and report JSON error with HTTP/501 when requesting users list.

fix #330

@rezib rezib added this to the v3.2.0 milestone Aug 20, 2024
@rezib rezib self-assigned this Aug 20, 2024
Response with HTTP/501 (not implemented) and descriptive JSON error when
requesting the list of users with authentication disabled.
Hide users disclosure from jobs filters panel when authentication is
disabled because gateway is unable to retrieve the list of users in this
case.

fix #330
@rezib rezib merged commit fea4d24 into main Aug 20, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
@rezib rezib deleted the pr/issue-330 branch August 20, 2024 10:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when filtering by Users. "AttributeError: 'NoneType' object has no attribute 'users'"
1 participant