Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid KeyError with warnings on old unsupported Slurm version #345

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Avoid KeyError with warnings on old unsupported Slurm version #345

merged 2 commits into from
Aug 30, 2024

Commits on Aug 30, 2024

  1. fix(agent): detect absence in slurmrestd warnings 

    Detect absence of warnings key in slurmrestd reponses and emit warning
log instead of crashing.

fix #316
    @rezib
    rezib committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    3e7c525 View commit details
    Browse the repository at this point in the history

  2. feat(agent): check slurm version 

    Check Slurm version as returned by slurmrestd against hard-coded minimal
version and log error if not greater or equal. This should help users to
understand the status with old Slurm versions with clear error message
rather than weird and unexpected behaviors.
    @rezib
    rezib committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c44206f View commit details
    Browse the repository at this point in the history