Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump requests from 2.27.1 to 2.31.0 #310

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 23, 2023

Bumps requests from 2.27.1 to 2.31.0.

Release notes

Sourced from requests's releases.

v2.31.0

2.31.0 (2023-05-22)

Security

  • Versions of Requests between v2.3.0 and v2.30.0 are vulnerable to potential forwarding of Proxy-Authorization headers to destination servers when following HTTPS redirects.

    When proxies are defined with user info (https://user:pass@proxy:8080), Requests will construct a Proxy-Authorization header that is attached to the request to authenticate with the proxy.

    In cases where Requests receives a redirect response, it previously reattached the Proxy-Authorization header incorrectly, resulting in the value being sent through the tunneled connection to the destination server. Users who rely on defining their proxy credentials in the URL are strongly encouraged to upgrade to Requests 2.31.0+ to prevent unintentional leakage and rotate their proxy credentials once the change has been fully deployed.

    Users who do not use a proxy or do not supply their proxy credentials through the user information portion of their proxy URL are not subject to this vulnerability.

    Full details can be read in our Github Security Advisory and CVE-2023-32681.

v2.30.0

2.30.0 (2023-05-03)

Dependencies

v2.29.0

2.29.0 (2023-04-26)

Improvements

  • Requests now defers chunked requests to the urllib3 implementation to improve standardization. (#6226)
  • Requests relaxes header component requirements to support bytes/str subclasses. (#6356)

... (truncated)

Changelog

Sourced from requests's changelog.

2.31.0 (2023-05-22)

Security

  • Versions of Requests between v2.3.0 and v2.30.0 are vulnerable to potential forwarding of Proxy-Authorization headers to destination servers when following HTTPS redirects.

    When proxies are defined with user info (https://user:pass@proxy:8080), Requests will construct a Proxy-Authorization header that is attached to the request to authenticate with the proxy.

    In cases where Requests receives a redirect response, it previously reattached the Proxy-Authorization header incorrectly, resulting in the value being sent through the tunneled connection to the destination server. Users who rely on defining their proxy credentials in the URL are strongly encouraged to upgrade to Requests 2.31.0+ to prevent unintentional leakage and rotate their proxy credentials once the change has been fully deployed.

    Users who do not use a proxy or do not supply their proxy credentials through the user information portion of their proxy URL are not subject to this vulnerability.

    Full details can be read in our Github Security Advisory and CVE-2023-32681.

2.30.0 (2023-05-03)

Dependencies

2.29.0 (2023-04-26)

Improvements

  • Requests now defers chunked requests to the urllib3 implementation to improve standardization. (#6226)
  • Requests relaxes header component requirements to support bytes/str subclasses. (#6356)

2.28.2 (2023-01-12)

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (75a1688) 96.85% compared to head (e2b95d9) 96.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files         113      113           
  Lines        5245     5245           
  Branches      281      281           
=======================================
  Hits         5080     5080           
  Misses        133      133           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! King!

@jchristgit jchristgit enabled auto-merge May 23, 2023 17:14
@jchristgit
Copy link
Collaborator

@thebeanogamer could you tack a review on this? Thank you

@jchristgit
Copy link
Collaborator

@thebeanogamer could you put a second review on this? Thank you

@jchristgit
Copy link
Collaborator

@thebeanogamer if your majesty has a moment, it would tickle my fancy for you to review this.

@jchristgit
Copy link
Collaborator

@thebeanogamer your highness, the security of the RACTF organization demands your attention, and it would deeply enjoy a review from you

@jchristgit
Copy link
Collaborator

@dependabot rebase

Bumps [requests](https://github.com/psf/requests) from 2.27.1 to 2.31.0.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.27.1...v2.31.0)

---
updated-dependencies:
- dependency-name: requests
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@jchristgit
Copy link
Collaborator

o great @thebeanogamer, angels shall sing should you sacrifice a sliver of time to peek your iris over this request on our project.

@jchristgit
Copy link
Collaborator

Grand @thebeanogamer, may you please lay aside a teardrop of a minute of your exquisite time to aid in guaranteeing the continuous security of our capture the flag platform.

@jchristgit jchristgit requested review from thebeanogamer and removed request for thebeanogamer August 8, 2023 10:34
@jchristgit
Copy link
Collaborator

Beloved @thebeanogamer, the importance of your timely review is now more important than ever, so in the name of the British people, I hereby request your humbleness to take a drop of your valued time to review this pull request.

@jchristgit
Copy link
Collaborator

@thebeanogamer, I am blissfully aware of the strong limitations imposed onto your very scarce pond of available time, but nevertheless, I would take great appreciation should you afford to expend a minute for reviewing this change.

@jchristgit
Copy link
Collaborator

@thebeanogamer The security of the Really Awesome Capture The Flag nonprofit security organization is paramount, and it has been in a constant state of threat ever since dependabot raised these critical issues to us. Could you sacrifice a pinch of your time to investigate this urgent matter?

Copy link
Contributor

@0xAda 0xAda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jchristgit jchristgit merged commit 5c9855e into master Sep 9, 2023
6 checks passed
@jchristgit jchristgit deleted the dependabot/pip/requests-2.31.0 branch September 9, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file priority: high quickwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants