Add frozen_string_literal: true comments and deprecate default_locale config accessor in favor of locale #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
frozen_string_literal: true
magic comment to all Ruby files..freeze
from string literals since that now happens automatically with the above comment.:pt
locale was pluralizing the shared"'lhão'"
string literal (withgsub!
) inside theLOTS
constant.default_locale
config accessor in favor of simplylocale
. (For compatibility the old accessors are still supported by alias.)Motivation for the deprecation: It was inconsistent that the
locale
config had adefault_
prefix, butdecimals_as
didn't. The README referred the them both as defaults, which makes sense...that's how configs usually work. So I figured the easy way to make them consistent was to drop thedefault_
prefix. Alternatively, we could add adefault_
prefix todecimals_as
. Or if it seems controversial, we could just drop the commit from this PR and consider it separately.