Skip to content

Commit

Permalink
use event.key instead of event.code
Browse files Browse the repository at this point in the history
  • Loading branch information
kochis committed Jun 13, 2024
1 parent 4d52226 commit 648f22a
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 17 deletions.
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Radar.initialize('prj_test_pk_...', { /* options */ });
Add the following script in your `html` file
```html
<script src="https://js.radar.com/v4.3.1-beta.0/radar.min.js"></script>
<script src="https://js.radar.com/v4.3.1-beta.1/radar.min.js"></script>
```

Then initialize the Radar SDK
Expand All @@ -73,8 +73,8 @@ To create a map, first initialize the Radar SDK with your publishable key. Then
```html
<html>
<head>
<link href="https://js.radar.com/v4.3.1-beta.0/radar.css" rel="stylesheet">
<script src="https://js.radar.com/v4.3.1-beta.0/radar.min.js"></script>
<link href="https://js.radar.com/v4.3.1-beta.1/radar.css" rel="stylesheet">
<script src="https://js.radar.com/v4.3.1-beta.1/radar.min.js"></script>
</head>

<body>
Expand All @@ -98,8 +98,8 @@ To create an autocomplete input, first initialize the Radar SDK with your publis
```html
<html>
<head>
<link href="https://js.radar.com/v4.3.1-beta.0/radar.css" rel="stylesheet">
<script src="https://js.radar.com/v4.3.1-beta.0/radar.min.js"></script>
<link href="https://js.radar.com/v4.3.1-beta.1/radar.css" rel="stylesheet">
<script src="https://js.radar.com/v4.3.1-beta.1/radar.min.js"></script>
</head>

<body>
Expand Down Expand Up @@ -130,8 +130,8 @@ To power [geofencing](https://radar.com/documentation/geofencing/overview) exper
```html
<html>
<head>
<link href="https://js.radar.com/v4.3.1-beta.0/radar.css" rel="stylesheet">
<script src="https://js.radar.com/v4.3.1-beta.0/radar.min.js"></script>
<link href="https://js.radar.com/v4.3.1-beta.1/radar.css" rel="stylesheet">
<script src="https://js.radar.com/v4.3.1-beta.1/radar.min.js"></script>
</head>

<body>
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "radar-sdk-js",
"version": "4.3.1-beta.0",
"version": "4.3.1-beta.1",
"description": "Web Javascript SDK for Radar, location infrastructure for mobile and web apps.",
"homepage": "https://radar.com",
"type": "module",
Expand Down
9 changes: 2 additions & 7 deletions src/ui/autocomplete.ts
Original file line number Diff line number Diff line change
Expand Up @@ -395,39 +395,34 @@ class AutocompleteUI {
}

public handleKeyboardNavigation(event: KeyboardEvent) {
// fallback to deprecated "keyCode" if event.code not set
const code = event.code !== undefined ? event.code : event.keyCode;
const key = event.key;

// allow event to propagate if result list is not open
if (!this.isOpen) {
return;
}

switch (code) {
switch (key) {
// Next item
case 'Tab':
case 'ArrowDown':
case 40:
event.preventDefault();
this.goTo(this.highlightedIndex + 1);
break;

// Prev item
case 'ArrowUp':
case 38:
event.preventDefault();
this.goTo(this.highlightedIndex - 1);
break;

// Select
case 'Enter':
case 13:
this.select(this.highlightedIndex);
break;

// Close
case 'Esc':
case 27:
this.close();
break;
}
Expand Down
2 changes: 1 addition & 1 deletion src/version.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export default '4.3.1-beta.0';
export default '4.3.1-beta.1';

0 comments on commit 648f22a

Please sign in to comment.