Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default attribution #109

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Add default attribution #109

merged 1 commit into from
Jul 25, 2023

Conversation

kochis
Copy link
Collaborator

@kochis kochis commented Jul 25, 2023

Default to showing map attribution, using the non-compact style

Screenshot 2023-07-25 at 1 58 16 PM

@kochis kochis requested a review from corypisano July 25, 2023 18:09
Copy link
Contributor

@corypisano corypisano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just confirming the compact: false need / managing the resizing

@@ -79,16 +82,28 @@ class MapUI {
link.appendChild(img)
map.getContainer().appendChild(link);

// add attribution
const attribution = new maplibregl.AttributionControl({ compact: false });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the default resizing/hiding attribution?

@kochis kochis merged commit 3d38293 into master Jul 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants