Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support providing input element for autocomplete ui #110

Merged
merged 1 commit into from
Aug 3, 2023
Merged

support providing input element for autocomplete ui #110

merged 1 commit into from
Aug 3, 2023

Conversation

kochis
Copy link
Collaborator

@kochis kochis commented Jul 26, 2023

  • Adds support for providing the <input> for autocomplete UI
image

jaspk06
jaspk06 reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@jaspk06 jaspk06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we only want to style <div> autocomplete elements and leave the styling up to the user if they provide an <input>? If so we should probably document that

@kochis
Copy link
Collaborator Author

kochis commented Jul 28, 2023

Yeah, that’s the intention. I’ll update the docs to make it more clear.

@kochis kochis marked this pull request as ready for review August 3, 2023 20:38
@kochis
support providing input element for autocomplete ui
70acd85 
fix bug when passing DOM object to autocomplete

allow keyboard events to propagate if result list is not open
@kochis kochis force-pushed the support-provided-input-for-autocomplete branch from 9fbd5c4 to 70acd85 Compare August 3, 2023 20:40
@kochis kochis merged commit bffa81d into master Aug 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaspk06 jaspk06 jaspk06 left review comments

@corypisano corypisano Awaiting requested review from corypisano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kochis @jaspk06