RadarMap.fitToMarkers class method
#156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump tsconfig target from es2015->es2016 for compatibility with class inheritence
kochis
reviewed
May 11, 2024
kochis
reviewed
May 11, 2024
src/ui/RadarMap.ts
Outdated
| markers.forEach(marker => { | ||
| bounds.extend(marker.getLngLat()); | ||
| }); | ||
| this.fitBounds(bounds, fitBoundsOptions); |
There was a problem hiding this comment.
What does this do if markers is empty? Also what's the deal with the animation options on this, do those need to be specified?
There was a problem hiding this comment.
added a no-op if markers is empty. Yeah you can pass in animation options into fitBoundsOptions https://docs.mapbox.com/mapbox-gl-js/api/map/#map#fitbounds
There was a problem hiding this comment.
just do fitMarkers({animate: false}) to disable animations. it uses map.flyTo by default
kochis
reviewed
May 15, 2024
kochis
approved these changes
May 15, 2024
- better handling of default fit to markers options
kochis
added a commit
that referenced
this pull request
Jun 6, 2024
* Radar map UI kit refactor (#153) * support custom style * custom markers * Maplibre control radar logo * bump version * refactor mapui kit by inheriting maplibre-gl - bump tsconfig target from es2015->es2016 for compatibility with class inheritence * pass request header override in map transformRequest * version bump * include custom style id in marker request * new marker logic * Delete .vscode directory * add .vscode/ to .gitignore * bump version * bump version * update transformRequest and add custom styles to demo page * marker updates * remove `getOptions` from `RadarMarker` * better way to handle custom markers and image urls * add custom url input to marker demo page * compliation target changes and copy changes * set beta version --------- Co-authored-by: Craig Kochis <[email protected]> * `RadarMap.fitToMarkers` class method (#156) * Map initalization `language` param (#161) * fix radar-default-v1 fallback regression * bump version * marker default width and height * bump version * `RadarMarker` popup improvements (#166) * bump version * Support click event on marker instance (#167) * support click handlers on markers * log map click * force popup on click * Update marker params (#168) * update marker params * handle popup.element * bump maplibre version in peer deps (#169) * img alt text * bump version * update dev version of maplibre-gl * fix marker image width and height * remove unused navigator * update browserlist * remove beta tag * support number and string for marker width/height * fix types --------- Co-authored-by: Jason Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: #153 needs to be reviewed first
single line function to adjust the bounds of a
RadarMapto fit to allRadarMarkeradded to the map.