Support new expiresAt/expiresIn/token/passed fields with trackOnce({ fraud: true }) and trackVerified() #159
Conversation
| @@ -212,8 +213,11 @@ export interface RadarTrackResponse extends RadarResponse { | |||
| events?: RadarEvent[]; | |||
| } | |||
|
|
|||
| export interface RadarTrackTokenResponse extends RadarResponse { | |||
| export interface RadarTrackVerifiedResponse extends RadarTrackResponse { | |||
There was a problem hiding this comment.
Could also be a separate interface instead of extending RadarTrackResponse
| constructor(message: string) { | ||
| super(message); | ||
| this.name = 'RadarLocationPermissionsError'; | ||
| this.name = 'RadarPermissionsError'; |
There was a problem hiding this comment.
To match mobile SDKs
| this.name = 'RadarDesktopAppError'; | ||
| this.status = 'ERROR_DESKTOP_APP'; | ||
| super('Radar Verify app not running.'); | ||
| this.name = 'RadarVerifyAppError'; |
There was a problem hiding this comment.
To account for Radar Verify desktop AND mobile apps
| constructor() { | ||
| super('Request timed out.'); | ||
| this.name = 'RadarTimeoutError'; | ||
| this.status = 'ERROR_TIMED_OUT'; | ||
| this.name = 'RadarNetworkError'; |
There was a problem hiding this comment.
To match mobile SDKs
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "radar-sdk-js", | |||
| "version": "4.1.18", | |||
| "version": "4.2.0-beta.0", | |||
There was a problem hiding this comment.
Are we shipping these changes as 4.2?
There was a problem hiding this comment.
Removing trackVerifiedToken() and renaming the error codes are breaking changes, so should prob be 4.2.x instead of 4.1.x
src/api/track.ts
Outdated
| if (expiresAt) { | ||
| expiresAt = new Date(expiresAt); | ||
| passed = user?.fraud?.passed && user?.country?.passed && user?.state?.passed; | ||
| expiresIn = expiresAt ? (expiresAt.getTime() - new Date().getTime()) / 1000 : null; |
There was a problem hiding this comment.
nit: It looks like expiresAt will also always be present here.
nit: You can also do Date.now() instead of new Date().getTime()
There was a problem hiding this comment.
Updated. @tderouin if we can expose expiresIn (in seconds, expiresAt - now) in the API response, I can also just remove this, along with passed
There was a problem hiding this comment.
| @@ -148,10 +148,6 @@ class Radar { | |||
| return VerifyAPI.trackVerified(params); | |||
| } | |||
|
|
|||
| public static trackVerifiedToken(params: RadarTrackParams = {}) { | |||
There was a problem hiding this comment.
If we don't want this to be a breaking change, could we potentially pass the params here to track width { fraud: true }?
Could also include a deprecation notice:
Logger.warn('DEPRECATED - trackVerifiedToken will be removed in a future release.');There was a problem hiding this comment.
Nobody uses this in prod yet (except for our demo page), so I think we're fine to skip this
| if (expiresAt) { | ||
| expiresAt = new Date(expiresAt); | ||
| passed = user?.fraud?.passed && user?.country?.passed && user?.state?.passed; | ||
| expiresIn = (expiresAt.getTime() - Date.now()) / 1000; |
There was a problem hiding this comment.
should the name be expiresInSeconds to be explicit? No strong opinion here because jwt uses expiresIn as well and just has the docs saying it is in seconds
There was a problem hiding this comment.
We don't really include units in the field name anywhere else in our APIs, so prefer to keep it expiresIn (if I could go back in a time machine to 2017 I might have used this pattern, but too late now, rather optimize for consistency and brevity)
trackOnce({ fraud: true }), return newtoken/expiresAt/expiresIn/passedfields. @tderouin right now we're calculatingexpiresInandpassedon the client, but cleaner to calculate them on the server. Could be a fast followtrackVerified()andtrackVerifiedToken(). Now just a single function which returns all ofuser/events/location/token/expiresAt/expiresIn/passed. No desktop app changes requiredRadarTimeoutError-->RadarNetworkError,RadarLocationPermissionsError-->RadarPermissionsError. Also renamesRadarDesktopAppErrortoRadarVerifyAppErrorgiven the addition of the Radar Verify mobile appsRadarLocationPermissionsErrorfor any location error, including location timeouts. Now we only returnRadarPermissionsErrorfor true permissions errors (code 1) andRadarLocationErrorfor location timeouts or unable to determine location (codes 2 and 3)