RadarMarker click event
#163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaspk06
commented
May 16, 2024
Comment on lines
+125
to
+137
| _onMapClick(e: maplibregl.MapMouseEvent): void { | ||
| const targetElement = e.originalEvent.target; | ||
| const element = this._element; | ||
|
|
||
| if (targetElement === element || element.contains(targetElement as any)) { | ||
| // TODO: Need to stop propagation somehow | ||
| // can use addEventListener in the constructor instead but then the togglePopup logic will be kinda wonky | ||
| if (this._popup) { | ||
| this.togglePopup(); | ||
| } | ||
| this.fire('click', this); | ||
| } | ||
| } |
There was a problem hiding this comment.
@kochis i screwed up the commits and the previous PR closed but to address your comment this is a method override
There was a problem hiding this comment.
this is the maplibre gl js implementation
https://github.com/maplibre/maplibre-gl-js/blob/3000ba109488c5503ce7719066ae0bd8a8100960/src/ui/marker.ts#L472-L479
There was a problem hiding this comment.
TODO: do not do method override. Add a click handler to the marker html element
kochis
reviewed
May 16, 2024
| const element = this._element; | ||
|
|
||
| if (targetElement === element || element.contains(targetElement as any)) { | ||
| // TODO: Need to stop propagation somehow |
There was a problem hiding this comment.
Can you explain this a bit more?
|
duplicate of: #167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RadarMarker. This is useful for attaching event listeners to the marker