Allow map event propagation on marker click #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to keep the event payload more in line with maplibre mouse events.
Since we're extending their
Markerclass, there's gonna be limitations as towards how flexible this event + event payload can be. Mainly, it's gonna be really tricky trying to stop event propagation to the map itself since all of maplibre's event are built using the map event listener. For example, they determine which element was "clicked" by checking if the event target contains the map element AND a marker in their own marker click handler. Their popup click handler is also tied to the map click event so we ideally we are not interfering with it.