Autocomplete fixes (race condition, prevent autofill, style fixes) #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaspk06
approved these changes
Jul 18, 2024
Comment on lines
+171
to
+173
| // disable browser autofill | ||
| this.inputField.setAttribute('autocomplete', 'off'); | ||
|
|
There was a problem hiding this comment.
do we wanna pass this in as an option to in case someone wants to use autofill?
There was a problem hiding this comment.
I think in that scenario, they can use their own input field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race Condition
There is a subtle race condition in the autocomplete component that exists when a previous request completes before the latest request. In the scenario where multiple requests are in-flight, the first request to complete sets the results (regardless if the user has typed more characters). The fix is to cancel any in-flight requests when another is issued.
Note: responses are manually throttled down in the examples to demonstrate the issue
Race Condition:
bad_query.mov
Fix:
good_query.mov