Add caching for custom markers form URLs #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kochis
commented
Aug 2, 2024
src/ui/RadarMarker.ts
Outdated
| @@ -29,6 +29,29 @@ interface ImageOptions { | |||
| height?: number | string; | |||
| } | |||
|
|
|||
| // cache URL loaded markers | |||
| const IMAGE_CACHE = new Map<string, Blob | string>(); | |||
There was a problem hiding this comment.
TODO: use enum here instead of string
kochis
commented
Aug 2, 2024
src/ui/RadarMarker.ts
Outdated
| const interval = setInterval(() => { | ||
| const cachedData = IMAGE_CACHE.get(url); | ||
| if (cachedData === 'pending') { | ||
| if (Date.now() - start > timeoutMS) { // expired |
There was a problem hiding this comment.
expired -> timed out
corypisano
reviewed
Aug 5, 2024
Comment on lines
+152
to
+158
| useCachedImage(markerOptions.url) | ||
| .then(onSuccess) | ||
| .catch((reason: 'miss' | 'timedout' | 'failed' | Error) => { | ||
| if (reason !== 'miss') { | ||
| Logger.debug(`RadarMarker: cache lookup for ${markerOptions.url}: ${reason}`); | ||
| } | ||
| }) | ||
| .catch(onError) | ||
| loadImage(); |
There was a problem hiding this comment.
might be nice to just have useCachedImage do the 1) check if in cache 2) if its not, load it
There was a problem hiding this comment.
The only think that makes it sorta tricky is the image loading happens differently depending on the type of marker being loaded (either from a remote URL, or via authenticated request to Radar). Can maybe play around with it.
There was a problem hiding this comment.
yea maybe could pass in a loadImage function, but not a huge deal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Network request for every marker image
markers-no-cache.mov
After
Single request for each marker URL used
markers-with-cache.mov