prevent /config call on multiple initializations #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmeier
reviewed
Nov 4, 2024
| @@ -58,6 +58,10 @@ class Radar { | |||
| throw new RadarPublishableKeyError('Secret keys are not allowed. Please use your Radar publishable key.'); | |||
| } | |||
|
|
|||
| if (Config.isInitialized()) { | |||
| Logger.error('Radar.initialize() called more than once.'); | |||
There was a problem hiding this comment.
Given that we're handling this, should we Logger.warn instead?
There was a problem hiding this comment.
I agree it's a "warn" and not an error, but I also sort of want this to fire on a production site. Maybe I will just change to console.warn instead of using the Logger class.
lmeier
reviewed
Nov 4, 2024
| // without having to mock the ConfigAPI.getConfig call | ||
| if (!(window as any)?.RADAR_TEST_ENV) { | ||
| ConfigAPI.getConfig(); | ||
| if (!Config.isInitialized()) { // only call getConfig on first initialization |
There was a problem hiding this comment.
Maybe we want to || keyChanged to handle cases where someone would change the key (can't come up with anything off the top of my head where that would matter here, but we do allow the key to change in Waypoint for instance)
There was a problem hiding this comment.
Yeah, that's the one scenario I was sort of thinking of.
Maybe it's worth just checking if the config options have changed or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/configBefore
After