Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect absolute path for straight-profiles for bootstrap install #1178

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

milanglacier
Copy link
Contributor

@milanglacier milanglacier commented Jan 20, 2025

Currently the bootstrap assumes that the lockfile path must be relative file relative to straight-base-dir/straight/versions,

however, some users might prefer to manage their lockfile in their version controlled dotfiles repo (~/.config/emacs/straight/versions), and manage the straight data under XDG spec, aka ~/.local/share/emacs/.

This patch updates the bootstrap script so that the user's lockfile file path is an absolute path, it will be used

@milanglacier
Copy link
Contributor Author

Hi, the CI error is:

make: *** [Makefile:101: docker] Error 2
Error: Process completed with exit code 2.

I have no idea what is this error. Looks like this is not an error from elisp but rather from build script?

@raxod502
Copy link
Member

Could we use expand-file-name instead of concat, which handles both files the same?

You can see the build error above in the log output:

image

@milanglacier milanglacier force-pushed the patch-1 branch 2 times, most recently from 1398404 to 02722c6 Compare January 21, 2025 02:37
@milanglacier
Copy link
Contributor Author

milanglacier commented Jan 21, 2025

Could we use expand-file-name instead of concat, which handles both files the same?

Thanks, updated. Good to know that expand-file-name can handle cases like this :) CI error is also fixed

Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx- looks like we don't need any version number bumps because this lives purely in install.el and is backwards compatible. You can ensure your new patch is available to your Emacs configuration when bootstrapping, by changing master to develop in the bootstrap snippet.

@raxod502 raxod502 merged commit 7e3d8a0 into radian-software:develop Jan 22, 2025
4 checks passed
@milanglacier milanglacier deleted the patch-1 branch January 22, 2025 09:00
@milanglacier milanglacier restored the patch-1 branch January 22, 2025 09:00
@milanglacier milanglacier deleted the patch-1 branch January 22, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants