Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #539 http: add client_id and authentication #543

Merged
merged 26 commits into from
Jan 21, 2025
Merged

Fix #539 http: add client_id and authentication #543

merged 26 commits into from
Jan 21, 2025

Conversation

robnagler
Copy link
Member

  • Removed backwards compatibility of implicit connect in call; Only one client, which is easily fixed, and connect is an important explicit step, which is async.

@robnagler robnagler requested a review from e-carlin January 15, 2025 22:50
@robnagler
Copy link
Member Author

@e-carlin hold off. Need to add something.

@robnagler
Copy link
Member Author

@e-carlin ready for a review. The tests were failing due to the parallelization and pksubprocess race condition unrelated to this PR. I think I made it more reliable. #544 will be a better fix, but not working on that now, since it's really an unlikely situation.

e-carlin
e-carlin approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@e-carlin e-carlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One pkdp. Other than that LGTM

pykern/http.py Outdated Show resolved Hide resolved
@robnagler robnagler merged commit c646065 into master Jan 21, 2025
3 checks passed
@robnagler robnagler deleted the 539-http-protocol branch January 21, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-carlin e-carlin e-carlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robnagler @e-carlin