Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial/tum #758

Merged
merged 11 commits into from
Jan 27, 2020
Merged

Tutorial/tum #758

merged 11 commits into from
Jan 27, 2020

Conversation

andre-merzky
Copy link
Member

This branch contains some documentation, example and code fixes from the Munich tutorial. Only functional change is to add file staging to the slurm adaptor.

Copy link
Contributor

@mturilli mturilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos and suggestions but once addressed, for me it is ready to go.

@andre-merzky
Copy link
Member Author

Thanks Matteo, that helped! I hope I addressed all comments.

@mturilli
Copy link
Contributor

All Travis tests fail. I would fix them before merging.

@andre-merzky
Copy link
Member Author

The ssh context adaptor tests fail - but I can't see why from the Travis output, they work locally as expected :-(

@andre-merzky andre-merzky merged commit 75f3a74 into devel Jan 27, 2020
@andre-merzky andre-merzky deleted the tutorial/tum branch January 27, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants