Memory-handling for feathering large cubes #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-koch
changed the title
e-koch
changed the title
|
@keflavich -- This is ready for a first review. VaryingRes cubes aren't handle yet, and there's a couple places where the memory handling might break (needing to reproject the SD cube). But the critical tests pass and it's in good enough shape to start stress-testing locally. |
keflavich
requested changes
May 23, 2022
docs/feathering_cubes.rst
Outdated
| expensive, the spectral-cube dask integration exposes an option to save temporary | ||
| intermediate products as zarr files. This is especially useful when rechunking the | ||
| data to optimize different computations (e.g., spectral versus spatial regridding.) | ||
| To enable this mode, `use_save_to_tmp_dir` can be enabled in `~uvcombine.feather_simple_cube`. |
There was a problem hiding this comment.
There was a problem hiding this comment.
Suggested change
| To enable this mode, `use_save_to_tmp_dir` can be enabled in `~uvcombine.feather_simple_cube`. | |
| To enable this mode, [`use_save_to_tmp_dir`](https://spectral-cube.readthedocs.io/en/latest/dask.html#saving-intermediate-results-to-disk) can be enabled in `~uvcombine.feather_simple_cube`. |
or... how do you do it with intersphinx? I can't remember. Argh.
There was a problem hiding this comment.
Think I've fixed this now...
…g need to repeat here
…sk operations yet
|
@keflavich -- Added some more checks and such. I think this is feature complete now and is at least running on ~few GB cubes for feathering, w/ and w/o dask. Dask VRSC isn't handled yet. I think that should be revisited later to get these adds wrapped up. |
keflavich
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #25.