Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature specs: Applications.Core/secretStores extended use cases #57

Merged
merged 25 commits into from
Mar 6, 2025
Merged

Feature specs: Applications.Core/secretStores extended use cases #57

merged 25 commits into from
Mar 6, 2025

Conversation

willtsai
Copy link
Contributor

Here are the feature specs for extending the use cases of Applications.Core/secretStores

superbeeny
superbeeny reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@superbeeny superbeeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have the one question around naming conventions for types.

willtsai added 3 commits August 1, 2024 15:39
@willtsai
add content
443523e 
Signed-off-by: Will Tsai <[email protected]>
@willtsai
add content
6131515 
Signed-off-by: Will Tsai <[email protected]>
@willtsai
address feedback on proposed examples
38a8ee3 
Signed-off-by: Will Tsai <[email protected]>
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 20, 2024
@github-actions GitHub Actions
Copy link

This pull request has been closed due to inactivity. Feel free to reopen if you are still working on it.

@github-actions github-actions bot closed this Aug 27, 2024
@willtsai willtsai reopened this Sep 16, 2024
@github-actions github-actions bot removed the Stale label Sep 17, 2024
@brooke-hamilton brooke-hamilton mentioned this pull request Sep 24, 2024
Closed
4 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

This pull request is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

This pull request has been closed due to inactivity. Feel free to reopen if you are still working on it.

@github-actions github-actions bot added the Stale label Jan 1, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

This pull request has been closed due to inactivity. Feel free to reopen if you are still working on it.

@github-actions github-actions bot closed this Jan 9, 2025
@willtsai willtsai reopened this Jan 16, 2025
@github-actions github-actions bot removed the Stale label Jan 17, 2025
nithyatsu
nithyatsu reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@nithyatsu nithyatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if I missed the conversation earlier, but with this feature, would there be changes to Credentials type that we use today for storing AZ and AWS secrets? If so, Then does secret store have to move into UCP's resource type?

@willtsai
Copy link
Contributor Author

not sure if I missed the conversation earlier, but with this feature, would there be changes to Credentials type that we use today for storing AZ and AWS secrets? If so, Then does secret store have to move into UCP's resource type?

This feature spec should not affect how we store AZ and AWS secrets, thanks for checking though!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2025

This pull request is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 8, 2025
@willtsai willtsai removed the Stale label Feb 10, 2025
@willtsai
Copy link
Contributor Author

still waiting on another round of reviews

kachawla
kachawla reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates - looks great! Left a few clarifying comments.

@willtsai willtsai merged commit 7e1d737 into radius-project:main Mar 6, 2025
2 checks passed
@willtsai willtsai deleted the secret-store-scenarios branch March 6, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvainsf sylvainsf sylvainsf left review comments

@rynowak rynowak rynowak left review comments

@superbeeny superbeeny superbeeny left review comments

@ytimocin ytimocin ytimocin left review comments

@nithyatsu nithyatsu nithyatsu left review comments

@lakshmimsft lakshmimsft lakshmimsft left review comments

@brooke-hamilton brooke-hamilton brooke-hamilton approved these changes

@kachawla kachawla kachawla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@willtsai @kachawla @sylvainsf @rynowak @superbeeny @ytimocin @brooke-hamilton @nithyatsu @lakshmimsft