Adding rad init command changes to support irsa #7761

vishwahiremat · 2024-07-24T16:49:06Z

Description

Added changes to rad init --full command to add types i.e accesskey,irsa while configuring aws provider
And adding prompts to accept role arn
refactoring the code with switch cases to handle it differently for both cases.
updated the tests

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Signed-off-by: Vishwanath Hiremath <[email protected]>

codecov · 2024-07-24T18:00:42Z

Codecov Report

Attention: Patch coverage is 67.34694% with 32 lines in your changes missing coverage. Please review.

Project coverage is 61.04%. Comparing base (4ba025d) to head (32a37e7).

Files	Patch %	Lines
pkg/cli/cmd/radinit/aws.go	70.90%	9 Missing and 7 partials ⚠️
pkg/cli/cmd/radinit/display.go	0.00%	12 Missing ⚠️
pkg/cli/cmd/radinit/environment.go	50.00%	1 Missing and 1 partial ⚠️
pkg/cli/cmd/radinit/init.go	92.30%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7761      +/-   ##
==========================================
- Coverage   61.05%   61.04%   -0.02%     
==========================================
  Files         523      523              
  Lines       27367    27432      +65     
==========================================
+ Hits        16710    16745      +35     
- Misses       9185     9207      +22     
- Partials     1472     1480       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/cli/aws/client.go

pkg/cli/cmd/radinit/aws.go

radius-functional-tests · 2024-07-25T18:19:15Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	vishwahiremat/radius
Commit ref	`660e1ae`
Unique ID	func8c23a1ca6e
Image tag	pr-func8c23a1ca6e

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func8c23a1ca6e
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func8c23a1ca6e
controller test image location: ghcr.io/radius-project/dev/controller:pr-func8c23a1ca6e
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func8c23a1ca6e
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Signed-off-by: Vishwanath Hiremath <[email protected]>

radius-functional-tests · 2024-08-06T20:28:20Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	vishwahiremat/radius
Commit ref	`cdae1e8`
Unique ID	funcb9636dc38f
Image tag	pr-funcb9636dc38f

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcb9636dc38f
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcb9636dc38f
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcb9636dc38f
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcb9636dc38f
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

ytimocin · 2024-08-06T20:28:22Z

pkg/cli/aws/provider.go

+// AwsCredentialKind - Aws credential kinds supported.
+type AwsCredentialKind string


What is the convention in our repository for Aws? Should it be AWS or do we use both Aws and AWS? I believe we should use AWS.

I see we are using mix of these 2 formats, mostly i see Aws in ucp code and AWS on the cli side. I have updated it to AWS format

pkg/cli/aws/provider.go

pkg/cli/azure/provider.go

ytimocin · 2024-08-06T20:30:27Z

pkg/cli/cmd/radinit/aws.go

 	selectAWSRegionPrompt                 = "Select the region you would like to deploy AWS resources to:"
+	selectAwsCredentialKindPrompt         = "Select a credential kind for the AWS credential:"


We use AWS and Aws in two lines that follow each other.

pkg/cli/cmd/radinit/aws.go

ytimocin · 2024-08-06T20:31:37Z

pkg/cli/cmd/radinit/aws.go

+			return nil, err
+		}
+
+		// Set the value for the Helm chart


We don't need these comments in production, I guess.

today i see comments in azure provider section as well, we can remove it if its not recommended https://github.com/vishwahiremat/radius/blob/b7484430568763f05fba769b325e6f0471092fcb/pkg/cli/cmd/radinit/azure.go#L127-L128

ytimocin · 2024-08-06T20:32:28Z

pkg/cli/cmd/radinit/aws.go

+	return r.Prompter.GetListInput(credentialKinds, selectAwsCredentialKindPrompt)
+}
+
+func (r *Runner) buildAwsCredentialKind() ([]string, error) {


This returns a list of available AWS credential kinds. Should we change the name? Also, can this ever return an error?

updated it to remove error from the return type.
and for the name today we follow the similar format in azure provider:

radius/pkg/cli/cmd/radinit/azure.go

Line 307 in b748443

func (r *Runner) buildAzureCredentialKind() ([]string, error) {

pkg/cli/cmd/radinit/environment.go

Signed-off-by: Vishwanath Hiremath <[email protected]>

ytimocin · 2024-08-06T22:27:15Z

pkg/cli/cmd/radinit/aws.go

+	return r.Prompter.GetListInput(credentialKinds, selectAWSCredentialKindPrompt)
+}
+
+func (r *Runner) buildAWSCredentialKind() []string {


I guess we can also change the name of the function. Are we building something here? Is this the convention we are using? Isn't it more like awsCredentialKinds?

this is format we used in azure, we are using the similar format in azure provider.

radius-functional-tests · 2024-08-06T22:45:30Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	vishwahiremat/radius
Commit ref	`32a37e7`
Unique ID	funcbdc2886d8b
Image tag	pr-funcbdc2886d8b

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcbdc2886d8b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcbdc2886d8b
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcbdc2886d8b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcbdc2886d8b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

# Description - Added changes to `rad init --full` command to add types i.e accesskey,irsa while configuring aws provider ![image](https://github.com/user-attachments/assets/da396b4d-5877-4772-a247-9ef6cf0c9e79) - And adding prompts to accept role arn - refactoring the code with switch cases to handle it differently for both cases. - updated the tests ## Type of change  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- Signed-off-by: Vishwanath Hiremath <[email protected]>

# Description - Added changes to `rad init --full` command to add types i.e accesskey,irsa while configuring aws provider ![image](https://github.com/user-attachments/assets/da396b4d-5877-4772-a247-9ef6cf0c9e79) - And adding prompts to accept role arn - refactoring the code with switch cases to handle it differently for both cases. - updated the tests ## Type of change  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- Signed-off-by: Vishwanath Hiremath <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]>

rad init changes for aws irsa

660e1ae

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat requested review from a team as code owners July 24, 2024 16:49

nithyatsu reviewed Jul 25, 2024

View reviewed changes

pkg/cli/aws/client.go Outdated Show resolved Hide resolved

nithyatsu reviewed Jul 25, 2024

View reviewed changes

pkg/cli/cmd/radinit/aws.go Outdated Show resolved Hide resolved

nithyatsu reviewed Jul 25, 2024

View reviewed changes

pkg/cli/cmd/radinit/aws.go Outdated Show resolved Hide resolved

nithyatsu reviewed Jul 25, 2024

View reviewed changes

pkg/cli/cmd/radinit/aws.go Outdated Show resolved Hide resolved

vishwahiremat temporarily deployed to functional-tests July 25, 2024 18:18 — with GitHub Actions Inactive

vishwahiremat added 2 commits July 29, 2024 14:07

Merge branch 'main' into vishwahiremat/rad-init-changes

2a37748

Signed-off-by: Vishwanath Hiremath <[email protected]>

addressing comments

1ac3be4

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat marked this pull request as draft July 30, 2024 21:56

vishwahiremat added 3 commits August 5, 2024 16:34

resolving merge conflicts

f2bb24a

Signed-off-by: Vishwanath Hiremath <[email protected]>

unit test fix

a3b5765

Signed-off-by: Vishwanath Hiremath <[email protected]>

addressing comment

cdae1e8

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat marked this pull request as ready for review August 6, 2024 19:53

vishwahiremat temporarily deployed to functional-tests August 6, 2024 20:27 — with GitHub Actions Inactive

ytimocin reviewed Aug 6, 2024

View reviewed changes

addressing comments

32a37e7

Signed-off-by: Vishwanath Hiremath <[email protected]>

ytimocin reviewed Aug 6, 2024

View reviewed changes

vishwahiremat temporarily deployed to functional-tests August 6, 2024 22:44 — with GitHub Actions Inactive

ytimocin approved these changes Aug 6, 2024

View reviewed changes

sk593 merged commit a4a4b90 into radius-project:main Aug 6, 2024
26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding rad init command changes to support irsa #7761

Adding rad init command changes to support irsa #7761

vishwahiremat commented Jul 24, 2024

codecov bot commented Jul 24, 2024 •

edited

Loading

radius-functional-tests bot commented Jul 25, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 6, 2024 •

edited

Loading

ytimocin Aug 6, 2024

vishwahiremat Aug 6, 2024

ytimocin Aug 6, 2024

vishwahiremat Aug 6, 2024

ytimocin Aug 6, 2024

vishwahiremat Aug 6, 2024

ytimocin Aug 6, 2024

vishwahiremat Aug 6, 2024

ytimocin Aug 6, 2024

vishwahiremat Aug 6, 2024

radius-functional-tests bot commented Aug 6, 2024 •

edited

Loading

		// AwsCredentialKind - Aws credential kinds supported.
		type AwsCredentialKind string

		selectAWSRegionPrompt = "Select the region you would like to deploy AWS resources to:"
		selectAwsCredentialKindPrompt = "Select a credential kind for the AWS credential:"

Adding rad init command changes to support irsa #7761

Adding rad init command changes to support irsa #7761

Conversation

vishwahiremat commented Jul 24, 2024

Description

Type of change

codecov bot commented Jul 24, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Jul 25, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Aug 6, 2024 • edited Loading

Radius functional test overview

Test Status

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Aug 6, 2024 • edited Loading

Radius functional test overview

Test Status

codecov bot commented Jul 24, 2024 •

edited

Loading

radius-functional-tests bot commented Jul 25, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 6, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 6, 2024 •

edited

Loading