Removing double imports found by staticcheck #7791
Conversation
Signed-off-by: ytimocin <[email protected]>
ytimocin
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7791 +/- ##
==========================================
- Coverage 61.05% 61.04% -0.02%
==========================================
Files 523 523
Lines 27367 27432 +65
==========================================
+ Hits 16710 16745 +35
- Misses 9185 9207 +22
- Partials 1472 1480 +8 ☔ View full report in Codecov by Sentry. |
| @@ -30,7 +30,6 @@ import ( | |||
| "github.com/radius-project/radius/pkg/cli/framework" | |||
| "github.com/radius-project/radius/pkg/cli/output" | |||
| "github.com/radius-project/radius/pkg/cli/workspaces" | |||
| "github.com/radius-project/radius/pkg/corerp/api/v20231001preview" | |||
There was a problem hiding this comment.
Is this something we could turn on in golanglint-ci? I think this is a good change, I'm just wondering how we could automate it.
There was a problem hiding this comment.
I found it by using staticcheck ./.... We can add that to a CI/CD we have.
There was a problem hiding this comment.
I did some research, it sounds like we should add staticcheck. I thought it was bundled into golanglint-ci but it isn't exactly, sounds like there is a history there.
# Description Removing double imports found by staticcheck ## Type of change - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). Signed-off-by: ytimocin <[email protected]>
# Description Removing double imports found by staticcheck ## Type of change - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). Signed-off-by: ytimocin <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]>
Description
Removing double imports found by staticcheck
Type of change