-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a check to a cast to the Recipe object #7797
Conversation
Signed-off-by: ytimocin <[email protected]>
recipe, ok := obj.(*radappiov1alpha3.Recipe) | ||
if !ok { | ||
return []reconcile.Request{} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unfortunate that there's no good way to return an error here. I agree that skipping is the most reasonable thing to do.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7797 +/- ##
==========================================
- Coverage 61.04% 61.04% -0.01%
==========================================
Files 523 523
Lines 27432 27434 +2
==========================================
Hits 16747 16747
- Misses 9206 9207 +1
- Partials 1479 1480 +1 ☔ View full report in Codecov by Sentry. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: Reshma Abdul Rahim <[email protected]>
Description
Adding a check to a cast to the Recipe object
Type of change