Removing unnecessary env vars from the LR workflow #8725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytimocin
requested a deployment
to
functional-tests
GitHub Actions
Waiting
ytimocin
force-pushed
the
ytimocin/wfls/lr/refactor/v0
branch
from
980a18d to
0d19dd3
Compare
ytimocin
requested a deployment
to
functional-tests
GitHub Actions
Waiting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8725 +/- ##
==========================================
+ Coverage 59.88% 59.90% +0.01%
==========================================
Files 596 596
Lines 40512 40512
==========================================
+ Hits 24261 24267 +6
+ Misses 14423 14419 -4
+ Partials 1828 1826 -2 ☔ View full report in Codecov by Sentry. |
lakshmimsft
previously approved these changes
Mar 4, 2025
lakshmimsft
reviewed
Mar 4, 2025
| echo "RAD_CLI_ARTIFACT_NAME=rad_cli_linux_amd64" >> $GITHUB_OUTPUT | ||
| echo "PR_NUMBER=${{ env.PR_NUMBER }}" >> $GITHUB_OUTPUT | ||
| echo "BICEP_RECIPE_TAG_VERSION=pr-${UNIQUE_ID}" >> $GITHUB_OUTPUT # Add this line |
There was a problem hiding this comment.
nit: we do not need " # Add this line"
Signed-off-by: ytimocin <[email protected]>
ytimocin
force-pushed
the
ytimocin/wfls/lr/refactor/v0
branch
from
0d19dd3 to
c446c7a
Compare
ytimocin
requested a deployment
to
functional-tests
GitHub Actions
Waiting
kachawla
reviewed
Mar 4, 2025
| # Container registry for storing container images | ||
| CONTAINER_REGISTRY: ghcr.io/radius-project/dev | ||
| # Container registry for storing Bicep recipe artifacts | ||
| BICEP_RECIPE_REGISTRY: ghcr.io/radius-project/dev | ||
| # The radius functional test timeout | ||
| FUNCTIONALTEST_TIMEOUT: 60m | ||
| TEST_TIMEOUT: 60m |
There was a problem hiding this comment.
Curious why are we changing this?
kachawla
reviewed
Mar 4, 2025
| @@ -110,16 +103,17 @@ jobs: | |||
| SKIP_BUILD: ${{ steps.skip-build.outputs.SKIP_BUILD }} | |||
| REL_VERSION: ${{ steps.gen-id.outputs.REL_VERSION }} | |||
| UNIQUE_ID: ${{ steps.gen-id.outputs.UNIQUE_ID }} | |||
| PR_NUMBER: ${{ steps.gen-id.outputs.PR_NUMBER }} | |||
kachawla
reviewed
Mar 4, 2025
| echo "RAD_CLI_ARTIFACT_NAME=rad_cli_linux_amd64" >> $GITHUB_OUTPUT | ||
| echo "PR_NUMBER=${{ env.PR_NUMBER }}" >> $GITHUB_OUTPUT | ||
| echo "BICEP_RECIPE_TAG_VERSION=pr-${UNIQUE_ID}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
What's the motivation to move it to uuid instead of release version?
kachawla
reviewed
Mar 4, 2025
kachawla
reviewed
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing unnecessary environment variables from the LR workflow for cleaning up some of the code.
Type of change
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: