Build images with artifacts outside of docker #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzuke
force-pushed
the
DO-2720
branch
27 times, most recently
from
9565803
to
f898a2b
Compare
dhedey
reviewed
Sep 18, 2024
docker/dockerfiles/java.dockerfile
Outdated
| COPY ./shell /radixdlt/shell | ||
| COPY ./keygen /radixdlt/keygen | ||
| # Need .git for tag versions - but this can probably be removed soon | ||
| COPY ./.git/* /radixdlt/.git/ |
There was a problem hiding this comment.
This should be able to be removed now
docker/dockerfiles/rust.dockerfile
Outdated
There was a problem hiding this comment.
Can we expand this to e.g. rust-build-base.dockerfile or something?
| RADIXDLT_ENGINE_STATE_API_PORT=3336 \ | ||
| RADIXDLT_ENGINE_STATE_API_BIND_ADDRESS=0.0.0.0 \ | ||
| RADIXDLT_NETWORK_ID=240 \ | ||
| RADIXDLT_NODE_KEY_CREATE_IF_MISSING=false |
There was a problem hiding this comment.
Everything up to here could be an app base image.
docker/dockerfiles/app.dockerfile
Outdated
|
|
||
| # Copy in the application artifacts | ||
| # The artifacts directory on the host must be populated with the required files. | ||
| COPY artifacts/*.jar /opt/radixdlt/lib/ |
There was a problem hiding this comment.
This doesn't allow building locally (as in docker build and ./run-docker.sh no longer work locally).
And it goes against the "build on same arch as run" mentality.
We historically had issues with arch and libc incompatibility doing it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.