create_balance_proof() should return a dictionary not a tuple

[pirapira]

Because then the return value can be used as **balance_proof instead of *balance_proof. That plays more nicely with the kwarg usage.

[pirapira]

See #1150 (comment) for an example.

[pirapira]

This approach does not work in a straightforward way. It's unclear how to name the signature.

closeChannel() wants

        bytes memory non_closing_signature,

while

create_balance_proof_countersignature() wants

        original_signature: bytes,

[pirapira]

• option 1: rename non_closing_signature into original_signature in the smart contract
• option 2: decompose the balance proof into members when necessary
• option 3: leave it as it is

I think, for now, option 2 is the most reasonable.

[pirapira]

#1272 fixed this.