Differentiate close and update signature checks #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
=======================================
Coverage 81.14% 81.14%
=======================================
Files 21 21
Lines 1453 1453
Branches 191 191
=======================================
Hits 1179 1179
Misses 231 231
Partials 43 43
Continue to review full report at Codecov.
|
karlb
suggested changes
Aug 1, 2019
This comment has been minimized.
This comment has been minimized.
pirapira
commented
Aug 12, 2019
pirapira
force-pushed
the
differentiate-close-and-update
branch
from
4a2f9bc to
b4dfc4c
Compare
pirapira
force-pushed
the
differentiate-close-and-update
branch
2 times, most recently
from
83b62b9 to
4001f97
Compare
updateNonClosingBalanceProof().
Now `pack_balance_proof` is used as often for the updating as the closing, so the default value makes less sense now.
Pylint doesn't understand balance_proof[:3] correctly, and it complained that msg_type argument appears twice.
There were two very similar functions sign_balance_proof_close_message() and sign_balance_proof_update_message(). These two are combined into sign_balance_proof_message().
create_balance_proof_closing_countersignature() and create_balance_proof_updating_countersignature() into create_balance_proof_countersignature()
for closeChannel() and updateNonClosingBalanceProof().
pirapira
force-pushed
the
differentiate-close-and-update
branch
from
f74f665 to
6bb17c9
Compare
palango
reviewed
Aug 15, 2019
palango
approved these changes
Aug 15, 2019
Merged
pirapira
added a commit
to pirapira/spec
that referenced
this pull request
Sep 3, 2019
This follows the implementation change in raiden-network/raiden-contracts#1150 Since Balance Proof Update message is used both for closeChnanel() and updateNonClosingBalanceProof() call, the signature must be differentiated using different message IDs.
pirapira
added a commit
to pirapira/spec
that referenced
this pull request
Sep 5, 2019
This follows the implementation change in raiden-network/raiden-contracts#1150 Since Balance Proof Update message is used both for closeChnanel() and updateNonClosingBalanceProof() call, the signature must be differentiated using different message IDs.
palango
pushed a commit
to raiden-network/spec
that referenced
this pull request
Sep 6, 2019
This follows the implementation change in raiden-network/raiden-contracts#1150 Since Balance Proof Update message is used both for closeChnanel() and updateNonClosingBalanceProof() call, the signature must be differentiated using different message IDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with different MessageTypeId's. This closes #1149.