Fix matching view's real column name #1133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #1131
The regex to match a view column to table column name was too vague, which could cause a similarly named view column to be matched.
The issue was found in v7.0.5.0 (containing #1126) but the issue was actually present in previous releases (eg: v7.0.4.0). The order that the view columns were declared affected whether the issue appeared or not.
For example if you had view declaration:
And performed regex of
CREATE\s+VIEW.*AS\s+SELECT.*\W([\w-]*)\s+AS\s+dt
on it then you would get match:If you changed the view declaration so that
dt_x
is beforedt
:Then the same regex would match:
In the fixed I remove the
CREATE VIEW ... AS SELECT ...
clause to simplify the regex to match the column name followed by a non-word character.