Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coerce test #1274

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Coerce test #1274

merged 1 commit into from
Dec 19, 2024

Conversation

aidanharan
Copy link
Contributor

Coerce CalculationsTest#test_should_count_with_group_by_qualified_name_on_loaded test.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/12397362939/job/34607551888

  1) Error:
CalculationsTest#test_should_count_with_group_by_qualified_name_on_loaded:
ActiveRecord::StatementInvalid: TinyTds::Error: Column 'accounts.firm_id' is invalid in the select list because it is not contained in either an aggregate function or the GROUP BY clause.
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:446:in `each'
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:446:in `handle_to_names_and_values'
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:67:in `internal_exec_sql_query'
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:25:in `perform_query'

@aidanharan aidanharan marked this pull request as ready for review December 19, 2024 10:19
@aidanharan aidanharan merged commit 2c9aad1 into main Dec 19, 2024
4 checks passed
@aidanharan aidanharan deleted the coerce-calculations-test branch December 19, 2024 10:19
@aidanharan aidanharan mentioned this pull request Jan 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan