Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated thread_safe option #101

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

alxckn
Copy link
Contributor

@alxckn alxckn commented Mar 28, 2024

The thread_safe option was introduced in the redis-rb's 2.2.à release. Its usage was removed in 2012 (redis/redis-rb@619fe28).

In newer versions of redis-rb (>= 5.0.0), deprecated options now result in an error raised:

Redis.new will now raise an error if provided unknown options.

This is a proposal to remove thread_safe: true in the documentation and tests as it is not used, incompatible with newer version of the redis-rb gem and in any case true is the default value.

@rosa
Copy link
Member

rosa commented Apr 3, 2024

Oh, totally, this must have been taken from other very old places 😅

@rosa rosa merged commit 5452a0a into rails:main Apr 3, 2024
5 checks passed
@rosa rosa mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants