Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing a Hash to lset command results in a client error with redisb >= 5.0.0 #102

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

alxckn
Copy link
Contributor

@alxckn alxckn commented Mar 28, 2024

@rosa
Copy link
Member

rosa commented Apr 3, 2024

Ohh, @alxckn, I think this is a bug in mission-control, I don't think lset should take a hash. Moreover, Resque itself seems to always pass a string there.

@rosa rosa marked this pull request as ready for review April 3, 2024 15:39
@alxckn
Copy link
Contributor Author

alxckn commented Apr 3, 2024

@rosa Thanks for reviewing my brain dump, I pushed it before a long week-end and wanted to come back to it ;)

@rosa
Copy link
Member

rosa commented Apr 3, 2024

Not at all, thanks for fixing! 🙏

@rosa rosa merged commit 923d5cc into rails:main Apr 3, 2024
5 checks passed
@rosa rosa mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants