Fix workers pagination issue where the whole relation was being loaded #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the delegation of all count-related methods to `to_a`, we were loading the whole set of workers when calculating the number of pages and page size, which happens before we've set any limits or offsets in the relation. Moreover, once the limits and offsets are set, we weren't resetting the loaded workers, which means we were still returning all of them even with offset and limit. This adds also a test for this and includes some minor cosmetic fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #28.
Due to the delegation of all count-related methods to
to_a, we were loading the whole set of workers when calculating the number of pages and page size, which happens before we've set any limits or offsets in the relation. Moreover, once the limits and offsets were set, we weren't resetting the loaded workers, which means we were still returning all of them even with offset and limit.I'd like to DRY a bit the two
JobsRelationandWorkersRelationclasses, which have a lot in common now, but this will do for now.