Chore: enrich sentry debugging #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
store invalid import files for later debugging
| @@ -38,6 +38,7 @@ def fetch_for_account(account) | |||
|
|
|||
| vmk_data = account.transport_client.VMK(safe_from.to_s(:db), safe_to.to_s(:db)) | |||
| return unless vmk_data | |||
| vmk_data = vmk_data.encode(vmk_data.encoding, universal_newline: true) | |||
There was a problem hiding this comment.
This seems kinda weird updating the variable itself instead of having a decoded_vmk_data or something similar. How did this work before? Does it not need to be encoded?
There was a problem hiding this comment.
Ah yes this can be named something else.
In short this ensures we have universal newlines and not some windows newlines as those create problems in the cmxl parser.
Any ideas for a name 😅
There was a problem hiding this comment.
Ah because vmk_data is just a string? Maybe just something like
Suggested change
| vmk_data = vmk_data.encode(vmk_data.encoding, universal_newline: true) | |
| vmk_data = account | |
| .transport_client.VMK(safe_from.to_s(:db), safe_to.to_s(:db)) | |
| &.encode(vmk_data.encoding, universal_newline: true) # converting windows newlines | |
| return unless vmk_data |
Comment on lines
39
to
+41
| vmk_data = account.transport_client.VMK(safe_from.to_s(:db), safe_to.to_s(:db)) | ||
| return unless vmk_data | ||
| vmk_data = vmk_data.encode(vmk_data.encoding, universal_newline: true) |
There was a problem hiding this comment.
Suggested change
| vmk_data = account.transport_client.VMK(safe_from.to_s(:db), safe_to.to_s(:db)) | |
| return unless vmk_data | |
| vmk_data = vmk_data.encode(vmk_data.encoding, universal_newline: true) | |
| vmk_data = account | |
| .transport_client.VMK(safe_from.to_s(:db), safe_to.to_s(:db)) | |
| &.then { it.encode(it.encoding, universal_newline: true) } | |
| return unless vmk_data |
There was a problem hiding this comment.
Honestly you can also just leave it as you did but add a comment. I thought it was encoding some bank data structures or something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are introduced?
upload invalid import files to sentry
Why are these changes introduced?
Have invalid import files in sentry next to the exception data for better error debugging
How are these changes made?
use sentry
add_attachmentfeatureHow was it tested? (optional)
remove this section, when you don't add further information
Some code, especially infrastructure code (say HELM or Kubernetes yaml files) are harder to test. So it’s important to let the reviewer know how you tested them in case you can’t check in tests. Alternatively, you can explain to the reviewer how to test it locally if necessary. Showing the results of tests you’ve run in this section if none are visible in the diff is also very helpful.