Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react-native-turbo-haptics #6264

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Add react-native-turbo-haptics #6264

merged 7 commits into from
Nov 19, 2024
+64 −43

Conversation

christianbaroni
Copy link
Member

What changed (plus any additional context for devs)

  • Adds react-native-turbo-haptics
  • Replaces instances of runOnJS(triggerHapticFeedback) with the new triggerHaptics
  • Tested on both iOS and Android

What to test

  • Should feel haptic feedback on iOS and Android when for example:
    • Submitting a swap
    • Dragging the swap slider to 0 or 100%

@socket-security Socket Security
Copy link

socket-security bot commented Nov 13, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 134 kB cbaroni

View full report↗︎

@brunobar79
Copy link
Member

Launch in simulator or device for 7640f8e

@brunobar79
Copy link
Member

Launch in simulator or device for 9321183

@brunobar79
Copy link
Member

Launch in simulator or device for a885c8a

@brunobar79
Copy link
Member

Launch in simulator or device for f783300

greg-schrammel
greg-schrammel approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@greg-schrammel greg-schrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@christianbaroni christianbaroni merged commit 9bf4998 into develop Nov 19, 2024
8 checks passed
@christianbaroni christianbaroni deleted the @christian/turbo-haptics branch November 19, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbbb maxbbb maxbbb approved these changes

@greg-schrammel greg-schrammel greg-schrammel approved these changes

@walmat walmat Awaiting requested review from walmat

@benisgold benisgold Awaiting requested review from benisgold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christianbaroni @brunobar79 @greg-schrammel @maxbbb