Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix token address searches on discover screen #6272

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix token address searches on discover screen #6272

wants to merge 1 commit into from
+52 −27

Conversation

maxbbb
Copy link
Contributor

@maxbbb maxbbb commented Nov 19, 2024

Fixes APP-1674

What changed (plus any additional context for devs)

  • Incorrectly named variable "params" was replaced with correctly named variable "queryParams", which fixed mainnet address searches throwing an error.
  • tokenSearch function logic was changed to more closely match search logic in src/__swaps__/screens/Swap/resources/search/search.ts which fixed cross-chain address search.

Screen recordings / screenshots

IMG_0397 2

What to test

  • Search for an exact address on the discover screen (ex "0x6982508145454Ce325dDbE47a25d4ec3d2311933")
  • Search normally

@linear Linear
Copy link

linear bot commented Nov 19, 2024

APP-1674 Discover search should lookup ERC20 addresses across chains using token search

@brunobar79
Copy link
Member

Launch in simulator or device for a01664d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat Awaiting requested review from walmat

@christianbaroni christianbaroni Awaiting requested review from christianbaroni

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxbbb @brunobar79