Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old search resource in favor of searchV2 resource #6443

Draft
wants to merge 27 commits into
base: @christian/query-store-token-search
Choose a base branch
from

Conversation

jinchung
Copy link
Member

@jinchung jinchung commented Feb 3, 2025

Fixes APP-####

What changed (plus any additional context for devs)

  1. Moved over handlers/deeplinks and ClaimCustomization that was still using search/search to now use Christian's new search/searchV2.
  2. Move DiscoverSearch to searchV2
  3. Deleted search/search

Screen recordings / screenshots

What to test

  • Test Discover search results behave as expected
  • Test deeplink handling for the swaps URL flow that it still behaves as expected
  • Test claiming USDC on different networks still works as part of the claim customization flow

@jinchung jinchung force-pushed the @jin/swap-search-update-rebase-discover branch from c19323a to 6411357 Compare February 5, 2025 16:42
@jinchung jinchung force-pushed the @jin/swap-search-update-rebase-discover branch from 6411357 to 602c006 Compare February 5, 2025 18:21
Base automatically changed from @jin/swap-crosschain-search to @christian/query-store-token-search February 6, 2025 14:43
@jinchung jinchung force-pushed the @jin/swap-search-update-rebase-discover branch from 48cb688 to 9b35d12 Compare February 11, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant