Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starter Reek config file ✨ Let's go through all the warnings from the defaults and check what we might want to override here. The YAML I'm committing now is not finalised!
Once it is finalised, we can configure a
pronto-reek
Github Action to comment on our PRs. I believe this would make more sense than blocking onpre-push
, like we do with Rubocop, because Reek design-oriented warnings may require more effort to fix.Reek does not support config inheritance, at least until troessner/reek#1512, so I thought we can reuse our config with something like
reek -c $(rf-stylez reek-config-path)
in the pronto action.Let's discuss!