Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrib async #141

Merged
merged 9 commits into from
Jul 2, 2024
Merged

Contrib async #141

merged 9 commits into from
Jul 2, 2024

Conversation

abdelaziz-mahdy
Copy link
Contributor

@abdelaziz-mahdy abdelaziz-mahdy commented Jul 1, 2024

fix #124

  • C wrappers
  • dart bindings
  • tests

@abdelaziz-mahdy abdelaziz-mahdy changed the base branch from main to async July 1, 2024 18:13
@abdelaziz-mahdy
Copy link
Contributor Author

i dont think this is my best work, but i got lost since it different than the ones before it , so let me know if there is something that is a problem and needs to be fixed

hopefully it should be all good

@abdelaziz-mahdy abdelaziz-mahdy marked this pull request as ready for review July 1, 2024 20:50
@rainyl
Copy link
Owner

rainyl commented Jul 2, 2024

i dont think this is my best work, but i got lost since it different than the ones before it , so let me know if there is something that is a problem and needs to be fixed

hopefully it should be all good

Great, I will review it.

@rainyl
Copy link
Owner

rainyl commented Jul 2, 2024

I think get/set properties are actually unnecessary to be asynchronous, in my test, it will be a little slower than synchronous calls, and getter/setter usually pass primitive types like int and double, it's fast enough to not block the main thread.

So, I am going to delete all async getter/setter, what do you think?

Copy link
Owner

@rainyl rainyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merging

@rainyl rainyl merged commit 6de1d8f into rainyl:async Jul 2, 2024
1 check passed
@abdelaziz-mahdy
Copy link
Contributor Author

I think get/set properties are actually unnecessary to be asynchronous, in my test, it will be a little slower than synchronous calls, and getter/setter usually pass primitive types like int and double, it's fast enough to not block the main thread.

So, I am going to delete all async getter/setter, what do you think?

I do agree that the overhead of running an isolate is not worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async Contrib
2 participants