-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contrib async #141
Contrib async #141
Conversation
i dont think this is my best work, but i got lost since it different than the ones before it , so let me know if there is something that is a problem and needs to be fixed hopefully it should be all good |
Great, I will review it. |
I think get/set properties are actually unnecessary to be asynchronous, in my test, it will be a little slower than synchronous calls, and getter/setter usually pass primitive types like int and double, it's fast enough to not block the main thread. So, I am going to delete all async getter/setter, what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for merging
I do agree that the overhead of running an isolate is not worth it. |
fix #124