Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make file auto clone #300

Merged
merged 2 commits into from
Nov 28, 2024
Merged

make file auto clone #300

merged 2 commits into from
Nov 28, 2024

Conversation

abdelaziz-mahdy
Copy link
Contributor

the make file will auto clone repo, before generating now since i saw you working on #299

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (0f1f788) to head (bc98fd4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          49       49           
  Lines        9129     9129           
=======================================
  Hits         8402     8402           
  Misses        727      727           
Flag Coverage Δ
unittests 92.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rainyl
Copy link
Owner

rainyl commented Nov 28, 2024

the make file will auto clone repo, before generating now since i saw you working on #299

Yes I have implemented the dart code, but havn't finished the tests, you can work on it if you are willing to. :)

And for the makefile, it seems you are cloning the rainyl/dartcv.git and moving it to packages/dartcv/src, why don't you use the submodule commands? I mean

# clone the repo and submodule
git clone https://github.com/rainyl/opencv_dart.git --recursive

# if you forgot --recursive during the cloning
git submodule update --init --recursive

# update to the latest commit of the submodule
git submodule update --remote

Therefore, I think if we want to simplify the above steps, just let make submodule_update to run git submodule update --init --recursive if the directory packages/dartcv/src is empty, else run git submodule update --remote, what do you think?

@abdelaziz-mahdy
Copy link
Contributor Author

Well, I didn't notice at first that these were submodules, so I updated the Makefile to make it work as you mentioned. Let me know what you think. (I think this is safer since anyone who wants to contribute can just run the make command.)

@rainyl
Copy link
Owner

rainyl commented Nov 28, 2024

Let me know what you think. (I think this is safer since anyone who wants to contribute can just run the make command.)

Sorry for my misleading 😢 . Agree it is safer, just do it~

@abdelaziz-mahdy
Copy link
Contributor Author

Let me know what you think. (I think this is safer since anyone who wants to contribute can just run the make command.)

Sorry for my misleading 😢 . Agree it is safer, just do it~

I already did 😅, and looks like it works correctly

@rainyl rainyl merged commit 618d4c3 into rainyl:main Nov 28, 2024
1 check passed
@rainyl
Copy link
Owner

rainyl commented Nov 28, 2024

@abdelaziz-mahdy Merged, thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants