-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make file auto clone #300
make file auto clone #300
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 49 49
Lines 9129 9129
=======================================
Hits 8402 8402
Misses 727 727
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yes I have implemented the dart code, but havn't finished the tests, you can work on it if you are willing to. :) And for the makefile, it seems you are cloning the # clone the repo and submodule
git clone https://github.com/rainyl/opencv_dart.git --recursive
# if you forgot --recursive during the cloning
git submodule update --init --recursive
# update to the latest commit of the submodule
git submodule update --remote Therefore, I think if we want to simplify the above steps, just let |
Well, I didn't notice at first that these were submodules, so I updated the Makefile to make it work as you mentioned. Let me know what you think. (I think this is safer since anyone who wants to contribute can just run the make command.) |
Sorry for my misleading 😢 . Agree it is safer, just do it~ |
I already did 😅, and looks like it works correctly |
@abdelaziz-mahdy Merged, thanks~ |
the make file will auto clone repo, before generating now since i saw you working on #299