Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add triangle function #56

Closed
wants to merge 2 commits into from
Closed

add triangle function #56

wants to merge 2 commits into from

Conversation

Jiinwoo
Copy link
Contributor

@Jiinwoo Jiinwoo commented May 17, 2024

First of all, thank you for providing this library.

I'm not familiar with dart and c++ languages, and I'm developing android and ios with flutter. I implemented the function using the repository, but I'm adding it because there are insufficient functions.

Can I check if the part I added can be done like this?
It's working as intended.

@Jiinwoo Jiinwoo marked this pull request as draft May 17, 2024 04:46
@Jiinwoo Jiinwoo marked this pull request as ready for review May 17, 2024 04:47
@rainyl
Copy link
Owner

rainyl commented May 17, 2024

Thanks~
I will review it quickly.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 88.46%. Comparing base (8deb960) to head (e8723f3).

Files Patch % Lines
lib/src/imgproc/imgproc.dart 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   88.64%   88.46%   -0.19%     
==========================================
  Files          34       34              
  Lines        4774     4784      +10     
==========================================
  Hits         4232     4232              
- Misses        542      552      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rainyl
rainyl previously requested changes May 17, 2024
lib/src/imgproc/imgproc.dart Show resolved Hide resolved
src/imgproc/imgproc.cpp Show resolved Hide resolved
@rainyl rainyl dismissed their stale review May 18, 2024 05:21

ignore

@rainyl
Copy link
Owner

rainyl commented May 18, 2024

I have no access to your repo so can't push to this PR, I am going to close this PR and create a new.

@rainyl rainyl closed this May 18, 2024
@rainyl rainyl mentioned this pull request May 18, 2024
@rainyl
Copy link
Owner

rainyl commented May 18, 2024

@Jiinwoo Thanks for your PR, I have finished cv.Subdiv2D in #60, and will be released in v1.0.4

@Jiinwoo
Copy link
Contributor Author

Jiinwoo commented May 20, 2024

Oh, thank you so much for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants